anygatecloud/strom
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: TestRealStorageResizeDirect and TestRealStorageDirectModeNoPalette bugs

Browse Source 
- resize() was writing to wrong array (r.data instead of newData) and using
  wrong elementsPerLong during resize loop
- TestRealStorageDirectModeNoPalette had invalid test data (0x1FFFF needs
  bpe>=17 but test used bpe=9)
This commit is contained in:
adman
2026-04-27 01:45:41 +02:00
parent e810a60848
commit 8a4e44760e
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
level/rrrr.go
+2 -2
View File
@@ -98,11 +98,11 @@ func (r *RealStorage) resize(bpe uint8) {
for i := range r.format.Len { for i := range r.format.Len {
var v int32 var v int32
if resizeDirect { if resizeDirect {
v = int32((r.data[i/r.elementsPerLong] >> ((i % r.elementsPerLong) * int32(r.bpe))) & r.mask) v, _ = r.Get(i)
} else { } else {
v = int32((r.data[i/r.elementsPerLong] >> ((i % r.elementsPerLong) * int32(r.bpe))) & r.mask) v = int32((r.data[i/r.elementsPerLong] >> ((i % r.elementsPerLong) * int32(r.bpe))) & r.mask)
} }
r.data[i/r.elementsPerLong] |= uint64(v) << ((i % r.elementsPerLong) * int32(bpe)) newData[i/int32(numberOfElements)] |= uint64(v) << ((i % int32(numberOfElements)) * int32(bpe))
} }
if resizeDirect { if resizeDirect {
r.palette = nil r.palette = nil
level/rrrr_test.go
+3 -3
View File
@@ -292,7 +292,7 @@ func TestRealStorageDirectModeNoPalette(t *testing.T) {
} }
data := make([]uint64, 36) data := make([]uint64, 36)
data[0] = 0x1FFFF data[0] = 0x1FF
s, err := format.ImportDataDirect(data) s, err := format.ImportDataDirect(data)
if err != nil { if err != nil {
@@ -303,8 +303,8 @@ func TestRealStorageDirectModeNoPalette(t *testing.T) {
if err != nil { if err != nil {
t.Fatalf("Get(0) failed: %v", err) t.Fatalf("Get(0) failed: %v", err)
} }
if got != 0x1FFFF { if got != 0x1FF {
t.Errorf("Get(0) = %d, want %d", got, 0x1FFFF) t.Errorf("Get(0) = %d, want %d", got, 0x1FF)
} }
} }